refactor: same treatment for get_shard_uids() as for shard_ids()
#10305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10305 +/- ##
==========================================
+ Coverage 68.19% 71.75% +3.56%
==========================================
Files 700 712 +12
Lines 141495 143098 +1603
Branches 141495 143098 +1603
==========================================
+ Hits 96489 102685 +6196
+ Misses 40455 35711 -4744
- Partials 4551 4702 +151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Longarithm
approved these changes
Dec 6, 2023
| self.shard_ids() | ||
| .map(|shard_id| ShardUId::from_shard_id_and_layout(shard_id, self)) | ||
| .collect() | ||
| /// Returns an iterator that iterates over all the shard uids for all the |
There was a problem hiding this comment.
Suggested change
| /// Returns an iterator that iterates over all the shard uids for all the | |
| /// Returns an iterator over all the shard uids for all the |
nit
There was a problem hiding this comment.
Thanks, even though it is more verbose I believe that the original is grammatically correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_shard_uids()toshard_uids()shard_uids()return an iterator instead of a vector.